OBPIH-5672 Show quantity issued only for approved items #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
added
the
warn: do not merge
jmiranda
requested changes
May 31, 2023
| @@ -328,6 +328,10 @@ class Location implements Comparable<Location>, java.io.Serializable { | |||
| return !onHold | |||
| } | |||
|
|
|||
| Boolean hasNoManagedInventoryAndSupportsSubmittingRequests() { | |||
There was a problem hiding this comment.
My only comment is that this method name does not roll off the tongue. I'll try to think of a way to simplify it.
There was a problem hiding this comment.
Changed to isDownstreamConsumer
| // if request FROM Ward then pull demand from origin to ward and use quantity counted as quantity on hand | ||
| if (requisitionInstance?.destination?.hasNoManagedInventoryAndSupportsSubmittingRequests()) { | ||
| // if request FROM "Ward" (location without managed inventory but supporting submitting requests), | ||
| // then pull demand from origin to that location |
There was a problem hiding this comment.
Let's no use "ward" because it could be all sorts of location types. Let's call it a downstream consumer. In fact, I think that's what I want the method to be called as well. Either of these sounds good to me.
Boolean isDownstreamConsumer()
Boolean isDownstreamEndpoint()
| @@ -243,7 +244,7 @@ class DocumentTemplateService { | |||
| requestorMonthlyDemand : demand?.monthlyDemand ?: 0, | |||
| requestorQuantityOnHand : quantityOnHand, | |||
| quantityRequested : requisitionItem?.quantity, | |||
| quantityIssued : requisitionInstance?.isPending() ? "" : requisitionItem?.quantityIssued | |||
| quantityIssued : requisitionItem.isApproved() && !requisitionInstance?.isPending() ? requisitionItem?.quantityIssued : "" | |||
There was a problem hiding this comment.
this could be encapsulated in a method like this ...
RequisitionItem.isQuantityAllocated()
or
RequisitionItem.isQuantityIssued()
depending on which one is more accurate.
awalkowiak
removed
the
warn: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.