OBPIH-5672 Add new custom document - Requisition template #4067
Conversation
| } | ||
|
|
||
| private createRequisitionContext(IXDocReport report, Requisition requisitionInstance) { | ||
| def requisitionItems = requisitionInstance?.requisitionItems?.collect { RequisitionItem requisitionItem -> |
There was a problem hiding this comment.
@jmiranda I had to go with this version either way, because couple of properties used are transients, and this was easier. I tested it on 150-200 items, and the performance was (imho) very good.
| def requisitionItems = requisitionInstance?.requisitionItems?.collect { RequisitionItem requisitionItem -> | ||
| def demand | ||
| def quantityOnHand | ||
| if (requisitionInstance?.destination?.isWard()) { |
There was a problem hiding this comment.
This logic makes me uneasy since there's no way to tell if demand is for a single location or it's aggregated. I think if there's we should only care about demand for the origin/destination pair and demand should be 0 if a demand record does not exist for that pair.
Can you ask Kelsey about this?
There was a problem hiding this comment.
One thing worth mentioning - if it was meant to be working for locations without MANAGE_INVENTORY and with SUBMIT_REQUEST, it won't, because isWard() checks only if locationTypeCode == LocationTypeCode.WARD
There was a problem hiding this comment.
@jmiranda Kelsey wanted to have it working like on add items page. Where it is working like that - if a request is from "ward" then pull demand from the origin to the requestor, and if a request is not from the "ward", then pull demand outgoing from the requestor to all other locations.
@kchelstowski I specifically asked if this is fine on Friday's standup because we are using exactly this in the stockMovementService.getAddPageItem and it was fine.
|
I am merging to start testing and I'll confirm the above concerns today and improve if needed. |
No description provided.