OBPIH-5237 Fix merging inventory items and PA when products had null … #3848
Conversation
…or empty lot number
| def obsoleteLotNumber = obsoleteInventoryItem?.lotNumber | ||
| def obsoleteExpirationDate = obsoleteInventoryItem?.expirationDate | ||
| return primaryInventoryItems?.find { | ||
| def exactLotNumber = obsoleteLotNumber ? (it.lotNumber == obsoleteLotNumber) : (it.lotNumber == null || it.lotNumber == "") |
There was a problem hiding this comment.
Don't forget about the whitespace case i.e. if someone enters more than one space character or worse ... tabs, returns, etc.
For readability, it might be better to move this method to Product.
| @@ -996,15 +996,10 @@ class ProductAvailabilityService { | |||
| existingPA.quantityAllocated += remainingPA.quantityAllocated | |||
| existingPA.quantityNotPicked += remainingPA.quantityNotPicked | |||
| existingPA.quantityOnHold += remainingPA.quantityOnHold | |||
| existingPA. quantityAvailableToPromise += remainingPA.quantityAvailableToPromise | |||
| existingPA.quantityAvailableToPromise += remainingPA.quantityAvailableToPromise | |||
There was a problem hiding this comment.
I know it's kind of long, but I'd prefer to spell existingPA out as existingProductAvailability for readability. Same with remainingPAs, et al.
Remind me why we need to do this instead of just rerunning the product availability once all transactions have been "fixed".
There was a problem hiding this comment.
@jmiranda I did all the requested changes. I do not remember why I went this route. I only remember that I initially did with the refresh, but then I changed to this approach and pushed this version in the first commit/PR for this feature.
#3848) * OBPIH-5237 Fix merging inventory items and PA when products had null or empty lot number * OBPIH-5237 Minor refactor after review
…or empty lot number