OBPIH-5026 Change naming in the product association import #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
reviewed
Oct 31, 2022
| @@ -26,7 +26,7 @@ class ProductAssociation { | |||
| String id | |||
| ProductAssociationTypeCode code | |||
| Product associatedProduct | |||
| BigDecimal quantity = 0 | |||
| BigDecimal quantity = 1 | |||
There was a problem hiding this comment.
This feels like a breaking change. What's the reason for this?
There was a problem hiding this comment.
@jmiranda To get rid of setting conversion by default to 1:0 (or 0:1) which (I think) makes no sense
There was a problem hiding this comment.
I restored the 0 here, if it might be breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.