OBPIH-3860 Show derived status on the orders list and details page #3438
Conversation
|
I am gonna merge, but I will revisit in case of any change request. |
| @@ -73,8 +73,13 @@ class OrderController { | |||
|
|
|||
| def orders = orderService.getOrders(orderTemplate, statusStartDate, statusEndDate, params) | |||
|
|
|||
| if (params.format && orders) { | |||
| def ordersDerivedStatus | |||
There was a problem hiding this comment.
In the future, you can just call something like this derivedOrderStatuses. Otherwise it's awkward to read.
| return [:] | ||
| } | ||
|
|
||
| def g = grailsApplication.mainContext.getBean('org.codehaus.groovy.grails.plugins.web.taglib.ApplicationTagLib') |
There was a problem hiding this comment.
We can also use the injected messageSource for this. But this seems fine.
| } | ||
|
|
||
| def g = grailsApplication.mainContext.getBean('org.codehaus.groovy.grails.plugins.web.taglib.ApplicationTagLib') | ||
| def orderSummaryList = OrderSummary.findAllByIdInList(orderIds) |
There was a problem hiding this comment.
I assume this method is going to be slow due to the use of the order summary. Are we in for a rude awakening come testing? Or do you think this will perform ok?
| @@ -220,6 +223,19 @@ | |||
| .datepicker('setDate', null); | |||
| }); | |||
| }); | |||
|
|
|||
| function fetchOrdersDerivedStatus() { | |||
There was a problem hiding this comment.
Oh interesting. When I wrote the "rude awakening" comment I was thinking that one way to deal with this would be to pull the data in asynchronously. So I guess we won't be rudely awakened.
No description provided.