Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBPIH-4428 Link HelpScout Beacon to localized articles. #3298

Merged

Conversation

mdpearson
Copy link
Member

No description provided.

@mdpearson mdpearson self-assigned this Jun 15, 2022
Copy link
Collaborator

@awalkowiak awalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdpearson I am gonna merge it as is, but I am wondering if this is good approach with the helpscout.beacon.key.labels. I am wondering if this should not be defined in the config.groovy. Plus do we care about these keys being exposed?

@awalkowiak awalkowiak merged commit 0b19cf8 into release/0.8.18 Jun 20, 2022
@awalkowiak awalkowiak deleted the OBPIH-4428-link-beacon-to-localized-articles branch June 20, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants