OBAM-357 Allow multiple invoice templates on single shipment workflow #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
requested changes
May 13, 2022
| @@ -45,8 +46,12 @@ class DocumentTemplateService { | |||
| Context context = new Context() | |||
| context.putVar("invoiceItems", shipmentInstance?.shipmentItems) | |||
| context.putVar("datePrinted", Constants.EUROPEAN_DATE_FORMATTER.format(new Date())) | |||
There was a problem hiding this comment.
Why are we hard-coding the date formatter here? I feel like this should be locale specific.
There was a problem hiding this comment.
This is good question, I do not remember
| context.putVar("destination", shipmentInstance?.destination) | ||
| context.putVar("originRequisitionCount", requisitionService.getRequisitionCountInCurrentFiscalYear(shipmentInstance?.origin)) | ||
| context.putVar("destinationRequisitionCount", requisitionService.getRequisitionCountInCurrentFiscalYear(shipmentInstance?.destination)) | ||
| JxlsHelper.getInstance().processTemplateAtCell(inputStream, outputStream, context, "Template!A1") |
There was a problem hiding this comment.
Template!A1 should probably be configurable. Just add something like the following to Config.groovy.
openboxes.documentTemplate.invoiceTemplate.targetCell = "Template!A1"
The "Template" part scares me. Is there no way to use the default tab's name?
There was a problem hiding this comment.
Do you mean the Sheet1?
| documentList << [ | ||
| name : documentTemplate?.name, | ||
| documentType: documentTemplate?.documentType?.name, | ||
| contentType : documentTemplate?.contentType, | ||
| stepNumber : null, | ||
| stepNumber : isInvoiceTemplate ? 5 : null, |
There was a problem hiding this comment.
We need to rethink this stepNumber thing at some point. I'll take the blame for that.
grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and OBAM-358 Add variables for custom document template