Step 4: Pick Page Modal forms and improvements #297
Conversation
- added Edit Pick modal form - added Adjust inventory modal form - added custom table for this step - added styling for crossed out rows - added temporary fix to font awesomes
|
@jmiranda looks like our 'react' tests passed and the test that failed is one of unit tests (test_list_shouldContainTwoProducts). |
|
Thanks @awalkowiak. I'll take a look. |
| @@ -79,3 +79,6 @@ renderField.defaultProps = { | |||
| arrayField: false, | |||
| label: '', | |||
| }; | |||
|
|
|||
| export const generateKey = () => | |||
There was a problem hiding this comment.
I assume this is for the random unique number needed for the stock movement. I don't love that Jesse wants to generate this unique ID BEFORE we save it to the database. But if that's really required, we'll add a REST endpoint for you guys to generate the ID as there's some config / logic that needs to be taken into consideration. For now, this is fine, but start to think about mocking an API here.
There was a problem hiding this comment.
This is just for generating keys for rows in table - array field (eslint does not like using array indexes as keys). This key won't be send to backend and won't be visible to user at any point.
| { | ||
| productCode: 1, | ||
| product: { code: 1, name: 'Advil 200mg' }, |
There was a problem hiding this comment.
Actually we should keep this as productCode as that's what will be returned by the API. And note that it's a string, not an integer.
There was a problem hiding this comment.
I made this change, to have same approach as on mocks from previous steps. I also assumed, that once we will have API, then we will need to make some small adjustments. However this can be easily changed in future.
There was a problem hiding this comment.
Awesome. And yes I figured the same (re: small adjustments). I'm just keeping an eye out to make sure I don't add too much burden to that effort once the APIs are actually ready.
https://tickets.pih-emr.org/browse/OBPIH-876
https://tickets.pih-emr.org/browse/OBPIH-880
https://tickets.pih-emr.org/browse/OBPIH-894