Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBPIH-874 Add react-modal library to handle modals #286

Merged
merged 2 commits into from
May 24, 2018
Merged

OBPIH-874 Add react-modal library to handle modals #286

merged 2 commits into from
May 24, 2018

Conversation

awalkowiak
Copy link
Collaborator

kkaczmarczyk
kkaczmarczyk reviewed May 23, 2018
View reviewed changes
Copy link
Collaborator

@kkaczmarczyk kkaczmarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping modals components in /modals directory?

@awalkowiak
Copy link
Collaborator Author

@kkaczmarczyk good point, but then i guess we should move 'steps' to separate folder too.

@kkaczmarczyk
Copy link
Collaborator

kkaczmarczyk commented May 23, 2018 •
edited
Loading

Makes sense - we can move'em in related commits in other tickets

@jmiranda jmiranda merged commit 044518d into develop May 24, 2018
@jmiranda jmiranda deleted the OBPIH-874 branch May 24, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkaczmarczyk kkaczmarczyk kkaczmarczyk left review comments

@jmiranda jmiranda jmiranda approved these changes

@pmuchowski pmuchowski pmuchowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awalkowiak @kkaczmarczyk @jmiranda @pmuchowski