Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple languages support. #276

Merged
merged 1 commit into from
May 16, 2018
Merged

Multiple languages support. #276

merged 1 commit into from
May 16, 2018

Conversation

awalkowiak
Copy link
Collaborator

Copy link
Member

@jmiranda jmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The format of the fr.js file scares me a bit as this file is something that will need to be edited by non-programmers. I assume this could be something where the messages.properties is the source of truth and we generate the translation files during bundling or something like that.

@jmiranda jmiranda merged commit 48a54ef into develop May 16, 2018
@jmiranda jmiranda deleted the OBPIH-853 branch May 16, 2018 16:34
@awalkowiak
Copy link
Collaborator Author

@jmiranda format of file can be simplified if it will cause troubles. I used this structure for navbar so i could easly generate menu dynamicaly. Further elements can be added to files with simpler - not nested structure and it should work too (as long as structure of both files - en and fr - will match). Example:
en = {
navbar: { nested as it is right now },
formStep1: {
field1: 'field1 in eng',
field2: 'field2 in eng',
}
...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants