Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a layout for new react pages that mimics the custom layout #273

Merged
merged 2 commits into from
May 14, 2018

Conversation

awalkowiak
Copy link
Collaborator

@awalkowiak
Copy link
Collaborator Author

@jmiranda just fyi, i moved layout (navbar) to react (footer is still located in gsp layout). For now (since we dont have authorization info on react side) all menu items are available. Once we get info from server what user can access then we filter out what is visible in menu. Same with footer - once api will work, then footer feature will be moved to react too.

@jmiranda
Copy link
Member

@awalkowiak Sounds good. In the future, if we end up having to do more of this type of work for anything (rendering, language support, etc) don't worry about leaving existing components out (e.g. footer.gsp) and implementing them with a no-op placeholders. For example, adding a somewhat empty footer would have been fine in this case as long as we add a ticket to implement / migrate the Bootstrap/React version later.

@awalkowiak
Copy link
Collaborator Author

@jmiranda yeah i kinda make it this way with breadcrumbs and search field (placeholders for now). I'll create tickets for those and for footer in backlog.

@jmiranda jmiranda merged commit cda6825 into develop May 14, 2018
@awalkowiak awalkowiak deleted the OBPIH-833 branch May 30, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants