Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBPIH-827: Update Travis CI build configuration #269

Merged
merged 5 commits into from
May 8, 2018
Merged

Conversation

pmuchowski
Copy link
Contributor

No description provided.

@jmiranda jmiranda added the status: work in progress For issues or pull requests that are in progress but not yet completed label Apr 27, 2018
Copy link
Member

@jmiranda jmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! As I mentioned in Slack, I'll take a stab at fixing those 12 failing unit tests. I can either do that as part of this PR or can create a new ticket.

@pmuchowski
Copy link
Contributor Author

I think it could be done it this PR, so when it's merged builds will be passing

@jmiranda
Copy link
Member

jmiranda commented May 7, 2018

Travis-ci builds are succeeding. I had to @ignore three tests because they required advanced mock capabilities that I couldn't figure out how to implement. I might rather add some integration tests for these anyway, but for now we're safe to @ignore them because the underlying features work fine when deployed.

@pmuchowski
Copy link
Contributor Author

@jmiranda I added the event with React tests, can you look at it and merge if it's fine

@jmiranda jmiranda merged commit 1fea30a into develop May 8, 2018
@jmiranda jmiranda deleted the OBPIH-827 branch May 8, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: work in progress For issues or pull requests that are in progress but not yet completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants