OBAM-172 First page of the bin replenishment wizard #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuchowski
reviewed
Sep 16, 2021
| eq("location", location) | ||
| eq("status", inventoryLevelStatus) | ||
| }.collect { Requirement requirement -> |
There was a problem hiding this comment.
why are you using collect here instead of findAll?
There was a problem hiding this comment.
I thought it will be an easier and cleaner way of getting rid of duplicates.
There was a problem hiding this comment.
in this case unique() should be fine
There was a problem hiding this comment.
Agree with @pmuchowski. Seems like each (iterate) would be better than collect (transform), but unique seems like the better option.
jmiranda
requested changes
Sep 17, 2021
| eq("location", location) | ||
| eq("status", inventoryLevelStatus) | ||
| }.collect { Requirement requirement -> |
There was a problem hiding this comment.
Agree with @pmuchowski. Seems like each (iterate) would be better than collect (transform), but unique seems like the better option.
pmuchowski
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.