OBPIH-3495: Migrate ProductPackage price into ProductPrice #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
requested changes
Jan 27, 2021
grails-app/controllers/org/pih/warehouse/order/OrderController.groovy
Outdated
Show resolved
Hide resolved
grails-app/migrations/0.8.x/changelog-2021-01-26-1100-migrate-price-into-product-price.xml
Show resolved
Hide resolved
grails-app/services/org/pih/warehouse/data/ProductSupplierDataService.groovy
Outdated
Show resolved
Hide resolved
grails-app/services/org/pih/warehouse/data/ProductSupplierDataService.groovy
Outdated
Show resolved
Hide resolved
awalkowiak
force-pushed
the
OBPIH-3495
branch
from
d6389a4
to
deed179
Compare
jmiranda
approved these changes
Jan 28, 2021
|
@awalkowiak I approved this but I just realized I need to take one more look at it before I merge. |
jmiranda
requested changes
Feb 1, 2021
There was a problem hiding this comment.
The one thing I don't see is the contact price. How are you handling that requirement? My assumption was that we'd add ProductPrice (contractPrice) to ProductSupplier. I think changing the productPackage.price to productPackage.productPrice might have been premature. Can you explain what requirement that fulfills?
| BigDecimal price | ||
| UnitOfMeasure currency | ||
|
|
||
| Date startDate |
There was a problem hiding this comment.
Let's go with the more conventional fromDate and thruDate to make it more descriptive. I don't mind startDate and endDate for reporting, but they're a little too generic for something like this.
grails-app/domain/org/pih/warehouse/product/ProductPackage.groovy
Outdated
Show resolved
Hide resolved
awalkowiak
commented
Feb 1, 2021
grails-app/controllers/org/pih/warehouse/product/ProductSupplierController.groovy
Outdated
Show resolved
Hide resolved
awalkowiak
force-pushed
the
OBPIH-3495
branch
from
deed179
to
73277e8
Compare
|
@jmiranda I made required changes |
jmiranda
reviewed
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.