OBPIH-2936,2937: Update product packages after uom edits on placed PO #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
requested changes
Aug 14, 2020
| @@ -696,6 +696,9 @@ class OrderController { | |||
| if (!order.save(flush:true)) { | |||
| throw new ValidationException("Order is invalid", order.errors) | |||
| } | |||
| orderService.updateProductPackage(orderItem) | |||
There was a problem hiding this comment.
This is going to update product package and unit price every time an order item is saved, not just when the order has already been placed.
There was a problem hiding this comment.
We should probably trigger an event to deal with this or just wrap this with an if statement to check if the order has been placed.
There was a problem hiding this comment.
@jmiranda Again I had something done in proper way first and then I decide to remove it. You're right this should be done only in the case after the order is placed. I added it as an if statement because I guess in the event it needs to be checked too.
|
@jmiranda as i did requested change, I am gonna merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.