OBPIH-2977 Fix expiration date display on packing list and receive pages #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
reviewed
Jun 17, 2020
| @@ -143,7 +143,7 @@ class ReceiptService { | |||
| partialReceiptItem.binLocation = binLocation | |||
| } | |||
| partialReceiptItem.lotNumber = shipmentItem.inventoryItem?.lotNumber | |||
| partialReceiptItem.expirationDate = shipmentItem.inventoryItem?.expirationDate | |||
| partialReceiptItem.expirationDate = shipmentItem.requisitionItem?.expirationDate ?: shipmentItem.inventoryItem?.expirationDate | |||
There was a problem hiding this comment.
This is not how I would expect this to work. I think if we're storing expiration date on the requisition item it would be temporarily for that page. But the value should actually be set on the inventory item. I need to discuss with Kelsey though because we may not want to override the expiry date but instead create a new inventory item.
jmiranda
added
the
warn: do not merge
|
Ticket was closed in October 2020 so closing PR as abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.