OBPIH-2769 Fix date created display on stock movement list page #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
approved these changes
Mar 30, 2020
jmiranda
requested changes
Mar 30, 2020
| @@ -91,7 +91,7 @@ | |||
| <g:formatDate format="MMM dd, yyyy" date="${stockMovement?.dateRequested}"/> | |||
| </td> | |||
| <td> | |||
| <g:formatDate format="MMM dd, yyyy" date="${stockMovement?.dateCreated}"/> | |||
| <g:formatDate format="MMM dd, yyyy" date="${stockMovement?.dateCreated ?: stockMovement?.requisition?.dateCreated}"/> | |||
There was a problem hiding this comment.
@DominikaHatala This would be what I would consider an implementation leak. We actually want to update the dateCreated on the stock movement object.
I'll try to deal with this myself but if I don't finish by tomorrow can you look into it. In particular I would look into the builder methods (createFromRequisition and createFromShipment) to see why the dateCreated is not populated correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.