OBPIH-2655: Allow editing pending purchase orders based SM #1518
Conversation
grails-app/controllers/org/pih/warehouse/order/OrderController.groovy
Outdated
Show resolved
Hide resolved
grails-app/services/org/pih/warehouse/order/OrderService.groovy
Outdated
Show resolved
Hide resolved
grails-app/services/org/pih/warehouse/order/OrderService.groovy
Outdated
Show resolved
Hide resolved
| if (!shipmentItem) { | ||
| shipmentItem = new ShipmentItem( | ||
| product: orderItem.product, | ||
| inventoryItem: orderItem.inventoryItem, |
There was a problem hiding this comment.
@awalkowiak orderItem.inventoryItem will probably be null 99% of the time, if not 100%. If there's a product and lot number specified then we need to do a look up of the InventoryItem by product and lot number. But I can't tell from the code what's going on here and whether we need to use InventoryService.findOrCreateInventoryItem() or InventoryService.findInventoryItemByProductAndLotNumber() or something else.
But all this logic looks complicated so let's have a discuss before we move this one forward. Can you enumerate the different use cases that are represented here:
- User goes back to edit order item quantity
- User goes back to edit order item product (?)
- ...
There was a problem hiding this comment.
@jmiranda you're right inventory item is not required here. I removed it. Use cases:
- edit line item (only qty)
- add new line item
- delete line item
There was a problem hiding this comment.
@awalkowiak But if there's a lot number and expiration date, it is required. Let's discuss on Slack.
No description provided.