Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBPIH-2116 Implement pagination in stock movement REST API #1423

Closed
wants to merge 1 commit into from
Closed

OBPIH-2116 Implement pagination in stock movement REST API #1423

wants to merge 1 commit into from

Conversation

dbienkowska
Copy link
Collaborator

No description provided.

@dbienkowska
Copy link
Collaborator Author

@jmiranda @awalkowiak PR updated

@dbienkowska dbienkowska force-pushed the OBPIH-2116 branch 2 times, most recently from bf39dcc to 979e26b Compare February 5, 2020 13:17
@dbienkowska
Copy link
Collaborator Author

@jmiranda @awalkowiak I have updated this PR with applied changes. I've also discussed with Artur that we don't really need EditPage, PickPage and PackPage classes - they only contain items and now we're fetching them separately.

@dbienkowska dbienkowska force-pushed the OBPIH-2116 branch 3 times, most recently from 9462416 to 5fab8ec Compare February 12, 2020 14:04
@jmiranda
Copy link
Member

@DominikaHatala Great job with this PR. I know it's been a huge pain but hopefully we're nearing the end. Once this gets merged to develop with the front-end PR we should rebase the PO feature branch to ensure that the refactoring I'm about to add there doesn't have any conflicts with these. @awalkowiak Can you help with the rebase if it looks like it's going to be a pain?

@awalkowiak
Copy link
Collaborator

@DominikaHatala were every change request from here fulfilled? If so, then we can close this pr, since we have this commit in PR with front end.

@dbienkowska
Copy link
Collaborator Author

@awalkowiak Yes, I'm closing this one.

@dbienkowska dbienkowska deleted the OBPIH-2116 branch January 7, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmiranda jmiranda jmiranda requested changes

@awalkowiak awalkowiak awalkowiak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbienkowska @jmiranda @awalkowiak