Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix 0.7.8 #141

Merged
merged 8 commits into from
Apr 28, 2016
Merged

Hotfix 0.7.8 #141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e559ed4
minor cleanup to prevent the assign identifier quartz job from throwi…
jmiranda Apr 21, 2016
f14f1e3
removed unnecessarily verbose logging from inventory service
jmiranda Apr 21, 2016
d8b9e6a
Purchase Order UI changes to make it more consistent with other pages
jmiranda Apr 21, 2016
5ff9422
fixed #133: added ability to import order line items into an existing…
jmiranda Apr 22, 2016
f0eafbe
fixed #50: Illegal attempt to associate a collection with two open se…
jmiranda Apr 22, 2016
532b47e
Minor enhancements to make UI a little more consistent across entire app
jmiranda Apr 22, 2016
0c91983
bumped app version to 0.7.8
jmiranda Apr 22, 2016
238af64
removed annoying inventory sampling report constraint
jmiranda Apr 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed #50: Illegal attempt to associate a collection with two open se… 
…ssions when receiving against purchase order
  • Loading branch information
@jmiranda
jmiranda committed Apr 22, 2016
commit f0eafbe24ce525f0f7e2aa91091a5535f0be6edf
2 changes: 1 addition & 1 deletion grails-app/services/org/pih/warehouse/inventory/InventoryService.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2079,7 +2079,7 @@ class InventoryService implements ApplicationContextAware {
inventoryItem.lotNumber = lotNumber
inventoryItem.expirationDate = expirationDate;
inventoryItem.product = product
inventoryItem.save()
inventoryItem.save(flush:true)
}
return inventoryItem

Expand Down
10 changes: 6 additions & 4 deletions grails-app/services/org/pih/warehouse/order/OrderService.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,12 @@ class OrderService {
// Find or create a new inventory item based on the product and lot number provided
def inventoryItem = null

// Need to use new session here otherwise it flushes the current session and causes an error
InventoryItem.withNewSession {
inventoryItem = inventoryService.findOrCreateInventoryItem(orderItemCommand.productReceived, orderItemCommand.lotNumber, orderItemCommand.expirationDate)
}
// Need to use withSession here otherwise it flushes the current session and causes an error
InventoryItem.withSession { session ->
inventoryItem = inventoryService.findOrCreateInventoryItem(orderItemCommand.productReceived, orderItemCommand.lotNumber, orderItemCommand.expirationDate)
session.flush()
session.clear()
}

def shipmentItem = new ShipmentItem();
shipmentItem.lotNumber = orderItemCommand.lotNumber
Expand Down