OBPIH-2416 Add validation for expiration dates #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbienkowska
force-pushed
the
OBPIH-2416
branch
from
8d51649
to
e9cbe00
Compare
jmiranda
requested changes
Dec 12, 2019
grails-app/controllers/org/pih/warehouse/inventory/InventoryItemController.groovy
Outdated
Show resolved
Hide resolved
dbienkowska
force-pushed
the
OBPIH-2416
branch
3 times, most recently
from
42232c1
to
3398f16
Compare
|
@jmiranda I have updated PR and applied requested changes. |
awalkowiak
reviewed
Dec 12, 2019
grails-app/controllers/org/pih/warehouse/inventory/InventoryItemController.groovy
Outdated
Show resolved
Hide resolved
| @@ -2469,6 +2469,7 @@ react.stockMovement.error.enterQuantity.label=Enter proper quantity | |||
| react.stockMovement.error.boxWithoutPallet.label=Please enter Pack level 1 before Pack level 2. | |||
| react.stockMovement.error.revertRequisitionItem.label=Could not revert requisition items | |||
| react.stockMovement.error.futureDate.label=The date cannot be in the future | |||
| react.stockMovement.error.invalidDate.label=This date is invalid. Please enter a date after 2000. | |||
There was a problem hiding this comment.
Same issue as in comment form file InventoryItemController.groovy
| @@ -2535,6 +2536,7 @@ react.partialReceiving.error.quantityShippedNegative.label=Quantity shipped can' | |||
| react.partialReceiving.error.futureDate.label=The date cannot be in the future | |||
| react.partialReceiving.error.dateBeforeShipment.label=The date cannot be before shipment date | |||
| react.partialReceiving.error.quantityToReceiveNegative.label=Quantity to receive can't be negative | |||
| react.partialReceiving.error.invalidDate.label=This date is invalid. Please enter a date after 2000. | |||
There was a problem hiding this comment.
Same issue as in comment form file InventoryItemController.groovy
| @@ -1453,6 +1453,7 @@ react.stockMovement.error.enterQuantity.label=Entrer la quantité correcte | |||
| react.stockMovement.error.boxWithoutPallet.label=Veuillez entrer le niveau d’emballage 1 avant le niveau d’emballage 2. | |||
| react.stockMovement.error.revertRequisitionItem.label=Impossible de reprendre les article de réquisition | |||
| react.stockMovement.error.futureDate.label=La date ne peut pas être dans le futur | |||
| react.stockMovement.error.invalidDate.label=Cette date n'est pas valide. Veuillez indiquer une date après 2000. | |||
There was a problem hiding this comment.
Same issue as in comment form file InventoryItemController.groovy
| @@ -1518,6 +1519,7 @@ react.partialReceiving.error.quantityShippedNegative.label=Quantité expediée n | |||
| react.partialReceiving.error.futureDate.label=La date ne peut pas être dans le futur | |||
| react.partialReceiving.error.dateBeforeShipment.label=La date ne peut pas être avant la date d’expédition | |||
| react.partialReceiving.error.quantityToReceiveNegative.label=Quantité à recevoir ne peut pas être negative | |||
| react.partialReceiving.error.invalidDate.label=Cette date n'est pas valide. Veuillez indiquer une date après 2000. | |||
There was a problem hiding this comment.
Same issue as in comment form file InventoryItemController.groovy
grails-app/services/org/pih/warehouse/inventory/InventoryService.groovy
Outdated
Show resolved
Hide resolved
grails-app/controllers/org/pih/warehouse/inventory/InventoryItemController.groovy
Outdated
Show resolved
Hide resolved
dbienkowska
force-pushed
the
OBPIH-2416
branch
from
3398f16
to
7bf1276
Compare
|
@DominikaHatala I'm going to merge this since you made my changes, but could you double check whether you made the changes requested by @awalkowiak as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.