OBPIH-2228 Add custom substitutions to substitution modal #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalkowiak
requested changes
Dec 10, 2019
|
@jmiranda please take a look on this feature |
dbienkowska
force-pushed
the
OBPIH-2228
branch
from
11695e4
to
6ac6107
Compare
dbienkowska
force-pushed
the
OBPIH-2228
branch
from
6ac6107
to
c506f86
Compare
awalkowiak
approved these changes
Dec 10, 2019
jmiranda
requested changes
Dec 13, 2019
| if (params.name && params.name.size() < minLength) { | ||
| render([data: []]) | ||
| return | ||
| } | ||
|
|
||
| String[] terms = params?.name?.split(",| ")?.findAll { it } | ||
| def products = productService.searchProducts(terms, []) | ||
| if(params.availableItems) { |
There was a problem hiding this comment.
I'm not comfortable using the product API in this way. Instead I think we should add a new endpoint.
/openboxes/api/products/:id/availableItems
Do you really need to get available items for more than one product at a time? If so we need to discuss this on Slack.
There was a problem hiding this comment.
@DominikaHatala I'm going to merge the PR as-is but we need to discuss refactoring this on an upcoming Monday call. This is an expensive and not something I want to do. I'd rather get available items for a single product at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.