Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBPIH-2275 Add new request stock feature #1190

Merged
merged 1 commit into from
Aug 28, 2019
Merged

OBPIH-2275 Add new request stock feature #1190

merged 1 commit into from
Aug 28, 2019

Conversation

dbienkowska
Copy link
Collaborator

No description provided.

jmiranda
jmiranda requested changes Aug 17, 2019
View reviewed changes
Copy link
Member

@jmiranda jmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ticket for feedback and requested changes. I also need Artur or Pawel to review the React changes when they get back.

@dbienkowska dbienkowska force-pushed the OBPIH-2275 branch 2 times, most recently from 6ab5c7b to 20ba0bc Compare August 26, 2019 12:03
awalkowiak
awalkowiak requested changes Aug 26, 2019
View reviewed changes
grails-app/i18n/messages.properties Outdated Show resolved Hide resolved
grails-app/i18n/messages_fr.properties Outdated Show resolved Hide resolved
grails-app/i18n/messages_fr.properties Outdated Show resolved Hide resolved
grails-app/i18n/messages_fr.properties Outdated Show resolved Hide resolved
grails-app/i18n/messages_fr.properties Outdated Show resolved Hide resolved
src/js/components/stock-movement-wizard/EditPage.jsx Show resolved Hide resolved
src/js/components/stock-movement-wizard/PackingPage.jsx Show resolved Hide resolved
src/js/components/stock-movement-wizard/PackingPage.jsx Show resolved Hide resolved
src/js/components/stock-movement-wizard/PickPage.jsx Show resolved Hide resolved
src/js/components/stock-movement-wizard/SendMovementPage.jsx Show resolved Hide resolved
@dbienkowska dbienkowska added status: ready for review Flags that a pull request is ready to be reviewed and removed needs work labels Aug 26, 2019
@awalkowiak
Copy link
Collaborator

@jmiranda Front looks good

@jmiranda jmiranda merged commit fff2520 into develop Aug 28, 2019
@jmiranda jmiranda deleted the OBPIH-2275 branch August 28, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmiranda jmiranda jmiranda requested changes

@awalkowiak awalkowiak awalkowiak approved these changes

@pmuchowski pmuchowski Awaiting requested review from pmuchowski

Assignees
No one assigned
Labels
status: ready for review Flags that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbienkowska @awalkowiak @jmiranda