OBPIH-6216 setup playwright project #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eslintrc.json
Outdated
| "rules": { | ||
| "simple-import-sort/imports": "error", | ||
| "simple-import-sort/exports": "error", | ||
| "quotes": ["error", "double"], |
There was a problem hiding this comment.
I know it's a different project, but since we used to use single quotes, shouldn't we keep it also there? Unless Playwright suggests to use double quotes and it's their convention.
There was a problem hiding this comment.
good point, I missed this rule in our main project.
I'll change it to single quotes and will reformat the code
.prettierrc.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "trailingComma": "es5", | |||
| "tabWidth": 4, | |||
There was a problem hiding this comment.
similar comment as above - we used to have tabWidth as 2.
package.json
Outdated
| "eslint-config-prettier": "9.1.0", | ||
| "eslint-config-standard-with-typescript": "37.0.0", | ||
| "eslint-plugin-playwright": "1.0.1", | ||
| "eslint-plugin-simple-import-sort": "^10.0.0", |
There was a problem hiding this comment.
Perhaps we could have a ~ for allowing patch releases?
…and reformat the project
awalkowiak
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.