Use a Tomcat image to run OpenBoxes release WAR #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tcarterBAMF! Apologies for the delay. I just noticed this PR while looking into upgrading our docker resources for the 0.9.x release. Beautiful work. I'll try to get the team to review and merge it next week. By the way, with the upcoming 0.9.x release we can run OpenBoxes using an embedded tomcat instance. I'm not sure if that improves anything beyond what you've done here, but it could lead to a size reduction (base image: jre vs tomcat+jre). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate Docker Compose configuration that uses a Tomcat docker image to run the WAR from a release version of OpenBoxes. It may be useful for folks that aren't trying to do OpenBoxes development with docker.