Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(token): document the token format #372

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

nobe4
Copy link
Contributor

@nobe4 nobe4 commented Jun 18, 2024

Add details on the format of OpenBao tokens, it should hopefully add clear documentation as to one can detect tokens.

The body's format was inferred from:

Resolves #369

Target Release

1.14.7

Copy link
Member

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cipherboy
Copy link
Member

@nobe4 Mind adding DCO git commit --amend --signoff? Thanks!

@nobe4
Copy link
Contributor Author

nobe4 commented Jun 18, 2024

@cipherboy, trying to do it at the moment, first time doing this 😬

@nobe4
Copy link
Contributor Author

nobe4 commented Jun 18, 2024

The DCO page was really helpful 👏
https://github.com/openbao/openbao/pull/372/checks?check_run_id=26370274219

@cipherboy cipherboy added docs Improvements or additions to documentation pr/no-changelog labels Jun 18, 2024
@cipherboy cipherboy merged commit 7276406 into openbao:main Jun 19, 2024
15 of 16 checks passed
@cipherboy cipherboy added this to the 2.0.0 - GA milestone Jun 19, 2024
@nobe4 nobe4 deleted the document-token-format branch July 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document token format
3 participants