Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum notes #1750

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add enum notes #1750

merged 1 commit into from
Jul 8, 2024

Conversation

333fred
Copy link
Contributor

@333fred 333fred commented Jul 6, 2024

Changes

The example in the enum extensions sections of the docs needs to have --enum specified on the command line to generate as expected, so I added a note for that so future developers aren't as confused as I was.

How to Review

This is a docs-only change, not much to review.

Checklist

  • Unit tests updated (n/a)
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript) (n/a)

The example in the enum extensions sections of the docs needs to have `--enum` specified on the command line to generate as expected, so I added a note for that so future developers aren't as confused as I was.
@333fred 333fred requested a review from a team as a code owner July 6, 2024 23:37
Copy link

changeset-bot bot commented Jul 6, 2024

⚠️ No Changeset found

Latest commit: e811de1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drwpow drwpow merged commit 35bd412 into openapi-ts:main Jul 8, 2024
7 checks passed
@333fred 333fred deleted the enum-docs branch July 8, 2024 17:13
kerwanp pushed a commit to kerwanp/openapi-typescript that referenced this pull request Jul 29, 2024
The example in the enum extensions sections of the docs needs to have `--enum` specified on the command line to generate as expected, so I added a note for that so future developers aren't as confused as I was.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants