Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to fix #22
This is replacing hard-coded compiler/linker flags in the source code of the project with pkg-config sourced info - works fine on mac and debian derivatives by default for me, since they all provide pc files for libfdk-aac with the appropriate include and lib locations.
If both the static and dynamic versions exist in the system, this will pick-up the dynamic one by default (unless the whole build is -static). If ONLY the static version exist, the static version will be picked-up in all cases without any modification of the go source code.
If one wants to force static linking of JUST fdk-aac, when both dyn and static versions are available on the system, one can manually edit the lib pc file.
As for what should happen in the dockerfile / future binary distribution of this project, I do believe it should be built fully statically (possibly including glibc - but more on that later with an updated dockerfile).
@AlbanSeurat let me know if you think this is an acceptable trade-off.
I do believe the upsides are: