Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestamps and strip extraneous whitespace in WebVTT output #219

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Fix timestamps and strip extraneous whitespace in WebVTT output #219

merged 2 commits into from
Oct 3, 2022

Commits on Oct 1, 2022

  1. Use two-digit hours in WebVTT timestamps 

    Per the WebVTT specification [0]:

> A WebVTT timestamp consists of the following components, in the given
> order:
>
> 1. Optionally (required if hours is non-zero):
>   1. Two or more ASCII digits, representing the hours as a base ten
>      integer.
>   2. A U+003A COLON character (:)

YouTube won’t accept timestamps containing single-digit hours.

[0] https://www.w3.org/TR/webvtt1/#webvtt-timestamp
    @tomstuart
    tomstuart committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    329f060 View commit details
    Browse the repository at this point in the history

  2. Strip segment text in WebVTT output 

    We already do this for plain text and SubRip output, so we should do it
for WebVTT too.
    @tomstuart
    tomstuart committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    2159e0f View commit details
    Browse the repository at this point in the history