Fix: disabling conditionning on previous text is not working as expected #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funboarder13920
changed the title
prompt_reset_since is set before all_tokens is extended hence does not have the expected effect.
funboarder13920
force-pushed
the
fix-condition_on_previous_text
branch
from
07dc00c
to
a248046
Compare
zackees
pushed a commit
to zackees/whisper
that referenced
this pull request
May 5, 2023
prompt_reset_since is set before all_tokens is extended hence does not have the expected effect.
ilanit1997
pushed a commit
to ilanit1997/whisper
that referenced
this pull request
May 16, 2023
prompt_reset_since is set before all_tokens is extended hence does not have the expected effect.
abyesilyurt
pushed a commit
to abyesilyurt/whisper
that referenced
this pull request
Nov 13, 2023
prompt_reset_since is set before all_tokens is extended hence does not have the expected effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
prompt_reset_since is set before all_tokens is extended hence does not have the expected effect if I interpret correctly the following description:
whisper/whisper/transcribe.py
Lines 81 to 84 in c09a7ae
I also moved the
result.temperature > 0.5condition but I am not sure it should be as it seems to be empirical. Let me know.