Update decoding.py #1155
Merged
Update decoding.py #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the suggestions of @Jeronymous in openai#914 and openai#924, it solves the problem of endless loop.
FernanOrtega
added a commit
to FernanOrtega/whisperX
that referenced
this pull request
Mar 27, 2023
New fix for endless loop problem. I also created a PR for official Whisper: openai/whisper#1155 It is explained in openai/whisper#914 and openai/whisper#924
|
Hi, looks like I can't add commits to your branch. Could you delete whitespaces in the two empty lines and also remove the line 17? |
Done! |
jongwook
reviewed
Apr 11, 2023
whisper/decoding.py
Outdated
| timestamp_last = timestamps[-1] | ||
| else: | ||
| timestamp_last = timestamps[-1] + 1 | ||
| logits[k, self.tokenizer.timestamp_begin: timestamp_last] = -np.inf |
There was a problem hiding this comment.
Suggested change
| logits[k, self.tokenizer.timestamp_begin: timestamp_last] = -np.inf | |
| logits[k, self.tokenizer.timestamp_begin : timestamp_last] = -np.inf |
whisper/decoding.py
Outdated
| @@ -14,7 +14,6 @@ | |||
| if TYPE_CHECKING: | |||
| from .model import Whisper | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please restore this deleted line
jongwook
reviewed
Apr 11, 2023
| @@ -471,6 +471,13 @@ def apply(self, logits: Tensor, tokens: Tensor): | |||
| # timestamps shouldn't decrease; forbid timestamp tokens smaller than the last | |||
| logits[k, self.tokenizer.timestamp_begin : timestamps[-1]] = -np.inf | |||
There was a problem hiding this comment.
Forgot to mention that this line is no longer needed but I'll fix it in a subsequent PR
Merged
MarkusMattinen
added a commit
to MarkusMattinen/whisper.cpp
that referenced
this pull request
Apr 27, 2023
MarkusMattinen
added a commit
to MarkusMattinen/whisper.cpp
that referenced
this pull request
Apr 27, 2023
MarkusMattinen
added a commit
to MarkusMattinen/whisper.cpp
that referenced
this pull request
May 3, 2023
zackees
pushed a commit
to zackees/whisper
that referenced
this pull request
May 5, 2023
* Update decoding.py Following the suggestions of @Jeronymous in openai#914 and openai#924, it solves the problem of endless loop. * Removed blank line and whitespaces in empty lines. * Suggested changes according to the linter --------- Co-authored-by: Jong Wook Kim <[email protected]>
ilanit1997
pushed a commit
to ilanit1997/whisper
that referenced
this pull request
May 16, 2023
* Update decoding.py Following the suggestions of @Jeronymous in openai#914 and openai#924, it solves the problem of endless loop. * Removed blank line and whitespaces in empty lines. * Suggested changes according to the linter --------- Co-authored-by: Jong Wook Kim <[email protected]>
MarkusMattinen
added a commit
to MarkusMattinen/whisper.cpp
that referenced
this pull request
May 30, 2023
MarkusMattinen
added a commit
to MarkusMattinen/whisper.cpp
that referenced
this pull request
May 30, 2023
abyesilyurt
pushed a commit
to abyesilyurt/whisper
that referenced
this pull request
Nov 13, 2023
* Update decoding.py Following the suggestions of @Jeronymous in openai#914 and openai#924, it solves the problem of endless loop. * Removed blank line and whitespaces in empty lines. * Suggested changes according to the linter --------- Co-authored-by: Jong Wook Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestions of @Jeronymous in #914 and #924, it solves the problem of endless loop.