Unexpected keyword argument 'bf16' : Modified train.py to handle exceptions appropriately #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the parameters within kwargs are checked if they are valid.
WuTheFWasThat
suggested changes
Dec 22, 2023
weak_to_strong/train.py
Outdated
| # If the error is not due to an unexpected keyword argument, re-raise it | ||
| raise | ||
|
|
||
| def try_initialize_model_with_kwargs_2(model_config, custom_kwargs, num_labels=2, linear_probe=False): |
There was a problem hiding this comment.
the only difference is device_map="auto"? you could just pass dict(**custom_kwargs, device_map="auto") and use a single function
weak_to_strong/train.py
Outdated
|
|
||
| # Remove the problematic keyword and retry | ||
| new_kwargs = {k: v for k, v in custom_kwargs.items() if k != problem_kwarg} | ||
| return try_initialize_model_with_kwargs(model_config, new_kwargs, num_labels, linear_probe) |
There was a problem hiding this comment.
this is a bug i think? recursing into the wrong function
|
Added the requested changes |
|
using #22 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a custom function that checks if the enlisted parameters within kwargs are valid.
If the type error is thrown, then the function ignores that specific parameter and checks for the other parameters.