fix: add content_filter and function_call to finish_reason #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rattrayalex
commented
Sep 19, 2023
|
r? @athyuttamre |
1 task
athyuttamre
reviewed
Sep 19, 2023
openapi.yaml
Outdated
Comment on lines
2511
to
2515
| `length` if the maximum number of tokens specified in the request was reached, | ||
| `content_filter` if content was omitted due to a flag from our content filters, | ||
| or `function_call` if the model decided to call a function. | ||
|
|
||
| enum: ["stop", "length", "content_filter", "function_call"] |
There was a problem hiding this comment.
This isn't quite right.
v1/completions only supports stop, length, and content_filter. v1/chat/completions supports all 4.
I think this line should be only the first three, and this line should have all 4 instead.
Could you update? Thanks!
rattrayalex
commented
Sep 19, 2023
There was a problem hiding this comment.
Oops, good catch @athyuttamre ! Got turned around. Re-review?
rattrayalex
commented
Sep 19, 2023
There was a problem hiding this comment.
Oops, good catch @athyuttamre ! Got turned around. Re-review?
rattrayalex
commented
Sep 19, 2023
There was a problem hiding this comment.
Oops, good catch @athyuttamre ! Got turned around. Re-review?
athyuttamre
approved these changes
Sep 19, 2023
rattrayalex
added a commit
to rattrayalex/openai-openapi
that referenced
this pull request
Sep 27, 2023
Missed this in openai#88, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would address openai/openai-node#320
I have not verified whether this or https://platform.openai.com/docs/guides/gpt/chat-completions-api is more accurate on this subject.