Mark function.parameters as required #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In openai/openai-node#181 (comment), a user claimed that a function without `parameters` specified will not be called, but the same function with `parameters: { 'type': 'object', properties: {} }` is called. This leads me to believe that the user should always pass `parameters`, even if they must be an empty object. A better approach to marking this required might be to make this the default on the server side, so that users do not need to pass this object for functions which accept no parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In openai/openai-node#181 (comment), a user claimed that a function without
parametersspecified will not be called, but the same function withparameters: { 'type': 'object', properties: {} }is called. This leads me to believe that the user should always passparameters, even if they must be an empty object.A better approach to marking this required might be to make this the default on the server side, so that users do not need to pass this object for functions which accept no parameters. However, in case that'll take some time to get to, I wanted to put up this PR for now to improve the DX in the meantime.