Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistants: fix "Logs" on RunStepUpdateCodeInterpreterOutput #52

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

trrwilson
Copy link
Collaborator

The InternalRunStepDeltaStepDetailsToolCallsCodeOutputLogsObject type derives from RunStepUpdateCodeInterpreterOutput, so the current call will infinitely recurse if the output is a logs instance. The property on the internal type was already renamed to handle this; this change just uses the intended InternalLogs target.

@trrwilson trrwilson enabled auto-merge (squash) June 12, 2024 22:56
@trrwilson trrwilson merged commit 207d597 into main Jun 14, 2024
1 check passed
@trrwilson trrwilson deleted the user/travisw/assistants-streaming-logs branch June 14, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants