Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cached/compiled Regex in InternalChatCompletionRequestMessageContentPartImageImageUrl #32

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Use cached/compiled Regex in InternalChatCompletionRequestMessageContentPartImageImageUrl #32

merged 1 commit into from
Jun 10, 2024

Conversation

stephentoub
Copy link
Contributor

No description provided.

@stephentoub
Use compiled Regex in InternalChatCompletionRequestMessageContentPart…
6be307f 
…ImageImageUrl

And source generated regex when the library eventually multitargets .NET 8
@trrwilson trrwilson merged commit efd76b5 into openai:main Jun 10, 2024
1 check passed
@stephentoub stephentoub deleted the usecompiledregex branch June 10, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephentoub @KrzysztofCwalina @trrwilson