Skip to content

Commit

Permalink
refactor: Moved InternalsVisibleTo to .csproj. (#19)
Browse files Browse the repository at this point in the history
  • Loading branch information
@HavenDV
HavenDV authored Jun 10, 2024
1 parent 52054b3 commit e6fe89c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 6 additions & 0 deletions src/OpenAI.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,10 @@
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
<PackageReference Include="System.ClientModel" Version="1.1.0-beta.4" />
</ItemGroup>

This comment has been minimized.

Sign in to view

Copy link
@RogerBarreto

RogerBarreto Aug 26, 2024 •
edited
Loading

Contributor

Wondering why the internals here are beneficial only for Azure.AI.OpenAI. 👀
Assume any APIs that can be consumed outside of this package should be public.

This comment has been minimized.

Sign in to view

Copy link
@KrzysztofCwalina

KrzysztofCwalina Aug 26, 2024

Collaborator

We will expose these APIs publicly at some point. For now, we want to keep them non-public because we want to be able to change details of their design and that would mean a breaking change in public APIs. Of course, such changes would break Azure.AI.OpenAI too, but we will coordinate such changes and absorb them.

This comment has been minimized.

Sign in to view

Copy link
@RogerBarreto

RogerBarreto Sep 18, 2024

Contributor

@KrzysztofCwalina Just curious, since the introduction of the [Experimental("OPENAI001")] would make sense to bring this constructor as an experimental, leaving room for changing its design without making it a azure only visible.

This comment has been minimized.

Sign in to view

Copy link
@KrzysztofCwalina

KrzysztofCwalina Sep 18, 2024

Collaborator

What's the benefit of doing this over what we are doing today?

This comment has been minimized.

Sign in to view

Copy link
@RogerBarreto

RogerBarreto Sep 18, 2024 •
edited
Loading

Contributor

@KrzysztofCwalina
The same benefit that Azure OpenAI SDK have on customizing the Pipeline, be able customize the pipeline, adapt to use TokenCredentials.

Basically if the answer is that it doesn't bring any benefit, Azure OpenAI SDK should be able to use the other public API constructor options and this one could be dropped for all means.

This comment has been minimized.

Sign in to view

Copy link
@KrzysztofCwalina

KrzysztofCwalina Sep 18, 2024

Collaborator

Are you saying that you would like packages other than Azure.OpenAI to be able to do what Azure.OpenAI does? If yes, then I agree, but we will enable this in a subsequent release. The experimental attribute is something new, we don't fully understand its implications, and so I would prefer to keep its usage to the minimum. I don't feel super strongly about that, so if others prefer to use the attribute, I would be OK with that.
<ItemGroup>
<InternalsVisibleTo Include="Azure.AI.OpenAI">
<PublicKey>0024000004800000940000000602000000240000525341310004000001000100097ad52abbeaa2e1a1982747cc0106534f65cfea6707eaed696a3a63daea80de2512746801a7e47f88e7781e71af960d89ba2e25561f70b0e2dbc93319e0af1961a719ccf5a4d28709b2b57a5d29b7c09dc8d269a490ebe2651c4b6e6738c27c5fb2c02469fe9757f0a3479ac310d6588a50a28d7dd431b907fd325e18b9e8ed</PublicKey>
</InternalsVisibleTo>
</ItemGroup>
</Project>
6 changes: 0 additions & 6 deletions src/Properties/AssemblyInfo.cs
View file

This file was deleted.

0 comments on commit e6fe89c

Please sign in to comment.