Make it deployable to Vercel #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco3
reviewed
May 2, 2024
README.md
Outdated
| ### 2. Set your [OpenAI API key](https://platform.openai.com/api-keys) | ||
| ```shell | ||
| export OPENAI_API_KEY="sk_..." | ||
| ### 2. Set your [OpenAI API key](https://platform.openai.com/api-keys) and [OpenAI Assistant ID](https://platform.openai.com/account/assistants) |
There was a problem hiding this comment.
I get 404 when trying to navigate to https://platform.openai.com/account/assistant
vasco3
reviewed
May 2, 2024
README.md
Outdated
|
|
||
| ```env | ||
| OPENAI_API_KEY="sk-123..." | ||
| OPENAI_ASSISTANT_ID="123..." |
There was a problem hiding this comment.
to be more explicit I would change to
OPENAI_ASSISTANT_ID="asst_..."
|
Thanks for this, totally makes sense! Just want to make sure the assistant setup flow still works with the new env var setup – might require an app restart instead of auto-updating on file save which is not as ideal, but going to poke around to see what I can get to work. |
|
Think I figured out a way that keeps the setup flow the same, but allows the env var to be set as well for Vercel deployment! |
ibigio
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assistantIdbe controlled by.env(process.env.OPENAI_ASSISTANT_ID)