Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated createAndStream method, use stream instead #10

Conversation

akkadaska
Copy link
Contributor

Fixes #8

This PR replaces the deprecated createAndStream method with the stream method. There is no difference in implementation between these two methods, which ensures a safe migration without affecting functionality.

Runs.createAndStream:
https://github.com/openai/openai-node/blob/dfae4097fae01f3ac49635e646876bd68d06cc3a/src/resources/beta/threads/runs/runs.ts#L126-L132

Runs.stream:
https://github.com/openai/openai-node/blob/dfae4097fae01f3ac49635e646876bd68d06cc3a/src/resources/beta/threads/runs/runs.ts#L190-L192

@romainhuet
Copy link
Contributor

Thank you @akkadaska! Good catch!

@romainhuet romainhuet merged commit 33e714e into openai:main May 3, 2024
@akkadaska akkadaska deleted the feature/replace-createAndStream-with-stream branch May 5, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createAndStream is deprecated
2 participants