Cleanup, removal of unmaintained code #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove python logging module - _step, _reset, _seed, _close => non underscored method - remove benchmark and scoring folder
… fail for people with underscore methods
fixed indentation disabled test_env_semantics
# Conflicts: # README.rst # gym/benchmarks/scoring.py # gym/envs/mujoco/half_cheetah.py # gym/envs/mujoco/hopper.py # gym/envs/mujoco/humanoid.py # gym/envs/mujoco/mujoco_env.py # gym/envs/mujoco/walker2d.py # gym/scoreboard/__init__.py # gym/scoreboard/api.py # gym/spaces/dict_space.py # gym/spaces/discrete.py # gym/spaces/multi_binary.py # gym/spaces/tests/test_spaces.py # gym/spaces/tuple_space.py # gym/wrappers/monitor.py # setup.py
|
Seems like some of these changes are breaking---maybe a version bump is in order? |
|
@joschu thank you for caring 🙏🏻 |
Closed
|
Hey @joschu, this breaks CarRacing-v0. Just a heads up. Edit: Oops just read your comment on this PR, I'm gonna take a stab at fixing CarRacing-v0 this around Saturday and see if I can make a PR to fix this. |
|
Hi, what is the different between |
|
Just a heads up - made some changes to CarRacing-v0 to address the problems introduced by the spec upgrade. PR: |
This was referenced Mar 20, 2018
wdoug
added a commit
to wdoug/gym
that referenced
this pull request
Apr 22, 2018
This cleans up some leftover changes after PR openai#836
pzhokhov
pushed a commit
that referenced
this pull request
Feb 26, 2019
This cleans up some leftover changes after PR #836
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Apr 24, 2020
* add dtype to Box
* remove board_game, debugging, safety, parameter_tuning environments
* massive set of breaking changes
- remove python logging module
- _step, _reset, _seed, _close => non underscored method
- remove benchmark and scoring folder
* Improve render("human"), now resizable, closable window.
* get rid of default step and reset in wrappers, so it doesn’t silently fail for people with underscore methods
* CubeCrash unit test environment
* followup fixes
* MemorizeDigits unit test envrionment
* refactored spaces a bit
fixed indentation
disabled test_env_semantics
* fix unit tests
* fixes
* CubeCrash, MemorizeDigits tested
* gym backwards compatibility patch
* gym backwards compatibility, followup fixes
* changelist, add spaces to main namespaces
* undo_logger_setup for backwards compat
* remove configuration.py
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Apr 24, 2020
This cleans up some leftover changes after PR openai#836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some aesthetic improvements and removed unmaintained parts of gym. This may seem like a downgrade in functionality, but it is actually a long-needed cleanup in preparation for some great new things that will be released in the next month.