Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify that custom code evals are not accepted #963

Merged
merged 2 commits into from
May 12, 2023
Merged

docs: Clarify that custom code evals are not accepted #963

merged 2 commits into from
May 12, 2023

Conversation

Ein-Tim
Copy link
Contributor

@Ein-Tim Ein-Tim commented May 12, 2023

Description

This PR provides a clear info statement, reg. the fact that custom code evals are currently not accepted.

README.md Outdated
@@ -13,6 +13,9 @@ To get set up with evals, follow the [setup instructions below](README.md#Setup)
- Familiarize yourself with the existing eval templates: [eval-templates.md](docs/eval-templates.md).

#### Writing evals

**Important: Please note that we are currenlty not accepting Evals with custom code, with the exception of modelgraded evals with custom code.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are accepting modelgraded evals with custom modelgraded YAML files, for example they contribute a new .yaml file to the registry here: https://github.com/openai/evals/tree/main/evals/registry/modelgraded

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to clarify, we will accept PRs that have new .yaml and new .jsonl (in git-lfs) files, but if they wrote new .py files, we unfortunately can't review them right now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will adapt the PR accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-review @andrew-openai.

Copy link
Contributor

@andrew-openai andrew-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrew-openai andrew-openai merged commit 5b2b19b into openai:main May 12, 2023
@Ein-Tim Ein-Tim deleted the update/custom-code-info branch May 12, 2023 19:49
@lucasklaassen
Copy link
Contributor

@andrew-openai would you be able to confirm that having custom .js files which help with building sample.jsonl inputs are okay? #981

I followed an example of an eval that was merged previously which followed this same pattern but can remove the javascript files if they are not valuable/allowed.

arbreton pushed a commit to arbreton/evals that referenced this pull request Jul 8, 2023
## Description

This PR provides a clear info statement, reg. the fact that custom code
evals are currently not accepted.
Linmj-Judy pushed a commit to TablewareBox/evals that referenced this pull request Feb 27, 2024
## Description

This PR provides a clear info statement, reg. the fact that custom code
evals are currently not accepted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants