Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[evals] moved modelgraded specs to registry #392

Merged
merged 2 commits into from
Mar 22, 2023
Merged

[evals] moved modelgraded specs to registry #392

merged 2 commits into from
Mar 22, 2023

Conversation

rlbayes
Copy link
Contributor

@rlbayes rlbayes commented Mar 21, 2023

  • each Eval now keeps track of "registry"

jwang47
jwang47 reviewed Mar 22, 2023
View reviewed changes
evals/registry.py Show resolved Hide resolved
evals/registry.py Outdated Show resolved Hide resolved
jwang47
jwang47 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@jwang47 jwang47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would also be good to have Andrew take a look

@rlbayes rlbayes merged commit aae522b into main Mar 22, 2023
Linmj-Judy pushed a commit to TablewareBox/evals that referenced this pull request Feb 27, 2024
@rlbayes
[evals] moved modelgraded specs to registry (openai#392)
0a3f07f 
- each Eval now keeps track of "registry"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwang47 jwang47 jwang47 approved these changes

@andrew-openai andrew-openai Awaiting requested review from andrew-openai andrew-openai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rlbayes @jwang47