Fix Pydantic warning on data_test run #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inwaves
requested review from
andrew-openai,
jwang47,
logankilpatrick,
etr2460 and
katyhshi
as code owners
etr2460
approved these changes
Dec 21, 2023
jacobbieker
pushed a commit
to withmartian/-ARCHIVED--router-evals
that referenced
this pull request
Jan 9, 2024
This PR fixes a warning from Pydantic when running the JSON dumps test in `data_test.py`: ``` evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps /evals/evals/data.py:191: PydanticDeprecatedSince20: The `json` method is deprecated; use `model_dump_json` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.5/migration/ for k, v in json.loads(o.json()).items() evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps /evals/lib/python3.9/site-packages/pydantic/main.py:1005: PydanticDeprecatedSince20: The `json` method is deprecated; use `model_dump_json` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.5/migration/ warnings.warn('The `json` method is deprecated; use `model_dump_json` instead.', DeprecationWarning) -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ```
Linmj-Judy
pushed a commit
to TablewareBox/evals
that referenced
this pull request
Feb 27, 2024
This PR fixes a warning from Pydantic when running the JSON dumps test in `data_test.py`: ``` evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps /evals/evals/data.py:191: PydanticDeprecatedSince20: The `json` method is deprecated; use `model_dump_json` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.5/migration/ for k, v in json.loads(o.json()).items() evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps evals/data_test.py::test_jsondumps /evals/lib/python3.9/site-packages/pydantic/main.py:1005: PydanticDeprecatedSince20: The `json` method is deprecated; use `model_dump_json` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.5/migration/ warnings.warn('The `json` method is deprecated; use `model_dump_json` instead.', DeprecationWarning) -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a warning from Pydantic when running the JSON dumps test in
data_test.py: