Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make decision prompt in ballots to send from system, not assistant #1439

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

james-aung
Copy link
Contributor

No description provided.

Copy link
Collaborator

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! injecting another system message part way through the conversation might be a bit confusing to the model, but assuming the eval still performs as expected this seems reasonable to me

@etr2460 etr2460 merged commit 070c761 into openai:main Dec 20, 2023
1 check failed
jacobbieker pushed a commit to withmartian/-ARCHIVED--router-evals that referenced this pull request Jan 9, 2024
Linmj-Judy pushed a commit to TablewareBox/evals that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants