Skip to content

Commit

Permalink
Change wrong kwargs name (#1435)
Browse files Browse the repository at this point in the history
Fix #1434 by changing the argument name to
`LangChainChatModelCompletionFn` in the registry.

## Final checklist 👀

### Submission agreement

By contributing to Evals, you are agreeing to make your evaluation logic
and data under the same MIT license as this repository. You must have
adequate rights to upload any data used in an Eval. OpenAI reserves the
right to use this data in future service improvements to our product.
Contributions to OpenAI Evals will be subject to our usual Usage
Policies (<https://platform.openai.com/docs/usage-policies>).

- [x] I agree that my submission will be made available under an MIT
license and complies with OpenAI's usage policies.

### Email address validation

If your submission is accepted, we will be granting GPT-4 access to a
limited number of contributors. Access will be given to the email
address associated with the commits on the merged pull request.

- [x] I acknowledge that GPT-4 access will only be granted, if
applicable, to the email address used for my merged pull request.

### Limited availability acknowledgment

We know that you might be excited to contribute to OpenAI's mission,
help improve our models, and gain access to GPT-4. However, due to the
requirements mentioned above and the high volume of submissions, we will
not be able to accept all submissions and thus not grant everyone who
opens a PR GPT-4 access. We know this is disappointing, but we hope to
set the right expectation before you open this PR.

- [x] I understand that opening a PR, even if it meets the requirements
above, does not guarantee the PR will be merged nor GPT-4 access be
granted.

### Submit eval

- [x] I have filled out all required fields of this form
- [x] I have used **Git LFS** for the Eval JSON data
- [x] (Ignore if not submitting code) I have run `pip install
pre-commit; pre-commit install` and have verified that `mypy`, `black`,
`isort`, `autoflake` and `ruff` are running when I commit and push

Failure to fill out all required fields will result in the PR being
closed.
  • Loading branch information
Lorenzo Pacchiardi committed Dec 21, 2023
1 parent dd38662 commit 02f35cc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion evals/registry/completion_fns/langchain_llms.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ langchain/chat_model/gpt-3.5-turbo:
class: evals.completion_fns.langchain_llm:LangChainChatModelCompletionFn
args:
llm: ChatOpenAI
chat_model_kwargs:
llm_kwargs:
model_name: gpt-3.5-turbo

0 comments on commit 02f35cc

Please sign in to comment.