Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yurivwarmerdam
Copy link

Hi, I have no idea if this is either a rude or polite thing to do, but I noticed a small missing dependency (for the jupyter notebook).
In any case, can't wait to play with this. Thank you for the repo!
(again, sorry if this is a rude thing to do. I've never tried to suggest a change to a stranger before, and have no idea what the conventions are.)

Hi, I have no idea if this is either a rude or polite thing to do, but I noticed a small missing dependency (for the jupyter notebook).
In any case, can't wait to play with this. Thank you for the repo!
(again, sorry if this is a rude thing to do. I've never tried to suggest a change to a stranger before, and have no idea what the conventions are.)
Copy link

@NomsterDude NomsterDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not rude by any means. If you notice a problem, you can suggest a fix. You did exactly what you're supposed to. The only problem is that I cant seem to find any mention of IPython in the code. Can you explain why IPython is a requirement? :)

@Naphier
Copy link

Naphier commented Aug 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants