Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): mdnsIpAddressList only if UA_HAS_GETIFADDR is undefined #6549

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

laroche
Copy link
Contributor

@laroche laroche commented Jun 17, 2024

In plugins/ua_config_json.c mdnsIpAddressList can only be set if UA_HAS_GETIFADDR is undefined.

@jpfr
Copy link
Member

jpfr commented Jun 18, 2024

Thanks for this.
Please add a comment before the #if to explain the situation why it is not needed with getifaddr activated.

@laroche
Copy link
Contributor Author

laroche commented Jun 18, 2024

Hello Julius Pfrommer,

does this update look good?

best regards,

Florian La Roche

In plugins/ua_config_json.c mdnsIpAddressList and mdnsIpAddressListSize
can only be set if UA_HAS_GETIFADDR is undefined.

Signed-off-by: Florian La Roche <[email protected]>
@jpfr jpfr merged commit b775832 into open62541:1.4 Jun 18, 2024
35 checks passed
@jpfr
Copy link
Member

jpfr commented Jun 18, 2024

Perfect. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants