Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server) copy mbedtls find cmake file #6531

Closed
wants to merge 1 commit into from

Conversation

andreasebner
Copy link
Contributor

For MbedTLS Version (<3) e.g. delivered with Ubuntu 20LTS, we need a dedicated cmake-find file (see Mbedtls 3.0 release notes "Add CMake package config generation for CMake projects consuming Mbed TLS." https://github.com/Mbed-TLS/mbedtls/releases/tag/v3.0.0). Therefore we have to copy the file during the make install.

@jpfr
Copy link
Member

jpfr commented Jun 4, 2024

Please check the mbedtls version for this.
I would prefer not to do this for the debian package.
So we don't collide with stuff that other projects should be doing.

Or have this in a file where we aggregate different helper macros...

@keba-estr
Copy link
Contributor

I also get a similar error with a debian bookworm armhf build:

CMake Error at /usr/share/cmake-3.25/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
By not providing "FindMbedTLS.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "MbedTLS", but
CMake did not find one.
Could not find a package configuration file provided by "MbedTLS" with any
of the following names:
MbedTLSConfig.cmake
mbedtls-config.cmake
Add the installation prefix of "MbedTLS" to CMAKE_PREFIX_PATH or set
"MbedTLS_DIR" to a directory containing one of the above files. If
"MbedTLS" provides a separate development package or SDK, be sure it has
been installed.
Call Stack (most recent call first):
/usr/lib/arm-linux-gnueabihf/cmake/open62541/open62541Config.cmake:50 (find_dependency)
CMakeLists.txt:34 (include)
-- Configuring incomplete, errors occurred!

@keba-estr
Copy link
Contributor

The following commit has an influence on this topic:
14c1d6f

@andreasebner
Copy link
Contributor Author

andreasebner commented Jun 5, 2024

The following commit has an influence on this topic: 14c1d6f

This was an issue and is solved in the latest release. But without the change in this PR, the FindMbedtls.cmake file (needed for mbedtls versions <3.0) is not copied to the install location. Since the copy process is more or less a workarround, we currently discuss on how to include it in a good manner.

@andreasebner
Copy link
Contributor Author

Solved with latest changes on 1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants