Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): export two more functions #6452

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

RolfKal
Copy link
Contributor

@RolfKal RolfKal commented May 1, 2024

This will allow compilation of examples/pubsub/server_pubsub_file_configuration.c when compiling open62541 library as shared library under Windows

@jpfr
Copy link
Member

jpfr commented Jun 26, 2024

I would split this as follows:

  • Add a method for parsing the PubSubConfiguration from the binary file (as a ByteString)
  • Add a method for loading the (already parsed) PubSubConfiguration(2).

That way, we are flexible to add JSON as a configuration format in the future.

As all the parts are already implemented, it is just a question of separating the concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants