Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)server: Allow server to access client ip address (github/open62… #5746

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpfj
Copy link

@mpfj mpfj commented Apr 18, 2023

…541#3303)

@jpfr
Copy link
Member

jpfr commented Apr 19, 2023

The intent is clear. We should support that.

Yet we try to keep the public API free from architecture-specific definitions. They should stay encapsulated within the /arch folder.

with the current approach it is sure to break on some architectures. And may even depend on ipv6 support.

Would it likewise work for you to give access to the discoveryUrl member variable of the client structure?

The discoveryurl either contains the ip or the host name that can be resolved.

@mpfj
Copy link
Author

mpfj commented Apr 19, 2023

I'm happy for any "generic" solution.
This custom fix worked for me and (apologies) I think I pushed the commit upstream by accident.

@johanneskopf
Copy link

An implementation of this feature would be much appreciated. Thanks for the work so far on this. I just commented to on the related issue here: #4219 . In my case, I ideally would need access to the IP Address as well as the hostname and URL (which is printed to the console, e.g. "urn:PC-NAME:UnifiedAutomation:UaExpert").

@johanneskopf
Copy link

@jpfr Thank you for your dedication to the Open62541 library. We're really interested in this feature and its integration timeline. Is it planned to implement this feature soon? Knowing the approximate timeframe would help us to plan accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants